On Sat, Jan 19, 2019 at 01:43:58AM +0000, Paul Walmsley wrote: > On Fri, 18 Jan 2019, Johan Hovold wrote: > > > Follow the Linux convention and treat devicetree nodes without a status > > property as enabled rather than disabled, while also allowing "ok" as a > > shorthand for "okay". > > > > Signed-off-by: Johan Hovold <jo...@kernel.org> > > Reviewed-by: Paul Walmsley <paul.walms...@sifive.com> > > ... although I probably would have phrased the commit message slightly > differently - something like "Use of_device_is_available() in > riscv_of_processor_hartid(), in place of an open-coded test." That frames > the change as one that removes custom code in place of an existing > standard function for the same purpose.
You're right, and that was my motivation too. In the end I decided to highlight the side effect in case someone was perhaps unknowingly relying on the current behaviour. Thanks for the review! Johan
