On Thu, Jan 17, 2019 at 11:29 AM Kevin Hilman <[email protected]> wrote: > > [ + Jianxin since Yixun is no longer at Amlogic ] > > Thomas Gleixner <[email protected]> writes: > > > On Mon, 12 Nov 2018, Thomas Gleixner wrote: > > > > Gentle ping. > > > >> Yixun, > >> > >> On Fri, 10 Nov 2017, Yixun Lan wrote: > >> > >> > +/* > >> > + * > >> > + * Copyright (c) 2016 BayLibre, SAS. > >> > + * Author: Neil Armstrong <[email protected]> > >> > + * > >> > + * Copyright (c) 2017 Amlogic, inc. > >> > + * Author: Yixun Lan <[email protected]> > >> > + * > >> > + * SPDX-License-Identifier: (GPL-2.0+ OR BSD) > >> > >> There are two things wrong: > >> > >> 1) The placement. See Documentation/process/license-rules.rst > >> > >> 2) BSD is not a valid license id. You really have to decide which BSD > >> variant to use. > >> > >> Please get that fixed as especially #2 is broken. The goal of using SPDX is > >> to provide reliable license information for compliance tools. > > > > This still is broken: > > > > # scripts/spdxcheck.py include/dt-bindings/ > > include/dt-bindings/reset/amlogic,meson-axg-reset.h: 9:41 Invalid License > > ID: BSD > > Jianxin, can you fix this and clarify which BSD license was intended by > Amlogic? > > If this isn't fixed soon, I will cleanup and remove the BSD part and > Amlogic can clarify with a subsequent patch.
Oops, nevermind. Looks like Jerome already did the cleanup. Kevin
