On 15/01/2019 15:36, Jitendra Khasdev wrote:
This patch is used to remove not necessary braces for single if block.Signed-off-by: Jitendra Khasdev <jkhas...@gmail.com> --- drivers/staging/comedi/comedi_fops.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/comedi_fops.c b/drivers/staging/comedi/comedi_fops.c index 5d2fcbfe02af..38980fad8be4 100644 --- a/drivers/staging/comedi/comedi_fops.c +++ b/drivers/staging/comedi/comedi_fops.c @@ -1605,9 +1605,9 @@ static int do_insn_ioctl(struct comedi_device *dev, unsigned int n_data = MIN_SAMPLES; int ret = 0;- if (copy_from_user(&insn, arg, sizeof(insn))) {+ if (copy_from_user(&insn, arg, sizeof(insn))) return -EFAULT; - } +n_data = max(n_data, insn.n);
The patch looks fine. Thanks for the fix! Reviewed-by: Ian Abbott <abbo...@mev.co.uk> -- -=( Ian Abbott <abbo...@mev.co.uk> || Web: www.mev.co.uk )=- -=( MEV Ltd. is a company registered in England & Wales. )=- -=( Registered number: 02862268. Registered address: )=- -=( 15 West Park Road, Bramhall, STOCKPORT, SK7 3JZ, UK. )=-
