On Mon, Dec 17, 2018 at 04:45:51PM +0100, Borislav Petkov wrote: >On Mon, Dec 17, 2018 at 09:27:28AM +0800, Chao Fan wrote: >> Oops, I thought you agree with what Baoquan said, so I send the new version >> and use simple_strtoull() back. > >I could've misunderstood him. Lemme repeat what I mean: > >- we should make kstrtoull() work because it is the right function to >use. Which means, include this too: > >https://lkml.kernel.org/r/20181216203113.ga23...@zn.tnic > >- we should gradually start replacing simple_strtoull() in >arch/x86/boot/ and eventually get rid of it. But that's for the TODO >list, to take care of later. > OK, got it. And I tested your solution(rename div_u64 as __div_u64, and div_u64_rem as __div_u64_rem)for the issue from test rebot, that works. Thank you very much.
Thanks, Chao Fan >- Take our time and stop with the hurrying and do the whole thing nice >and clean. > >Ok? > >Or have I forgotten something? > >If not, I'll continue looking at your v13. > >Thx. > >-- >Regards/Gruss, > Boris. > >Good mailing practices for 400: avoid top-posting and trim the reply. > >