On Thu, Dec 13, 2018 at 02:25:30PM -0500, Masayoshi Mizuma wrote:
> > + len = cmdline_find_option("acpi_rsdp", val, MAX_ADDRESS_LENGTH+1);
>
> sizeof() is better here.
>
> len = cmdline_find_option("acpi_rsdp", val, sizeof(var));
Why is it better?
That makes you go look for the "val" variable and see what it's size is.
MAX_ADDRESS_LENGTH+1 is OTOH explicit.
>
> > + if (len > 0) {
> > + val[len] = 0;
>
> '\0' should be fine here not 0.
>
> val[len] = '\0';
Yes.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
