On 2018/12/11 10:16, Liu, Chuansheng wrote: > We may enhance it by: > - if (sysctl_hung_task_warnings) { > + if (sysctl_hung_task_panic || sysctl_hung_task_warnings) { > if (sysctl_hung_task_warnings > 0) > sysctl_hung_task_warnings--;
Why ignore sysctl_hung_task_warnings? The administrator can already configure as sysctl_hung_task_warnings == -1 && sysctl_hung_task_panic == 1 if he/she does not want to suppress neither sched_show_task() nor debug_show_all_locks()/trigger_all_cpu_backtrace(). Someone might want that sysctl_hung_task_warnings == 0 (which is a request to suppress only sched_show_task()) should not be ignored by sysctl_hung_task_panic == 1 (which is a request to trigger panic).