On Sun, Dec 09, 2018 at 08:40:29PM +0100, Greg KH wrote:
> On Sun, Dec 09, 2018 at 09:27:01AM -0800, Joe Perches wrote:
> > On Sun, 2018-12-09 at 17:20 +0100, Greg KH wrote:
> > > On Sun, Dec 09, 2018 at 04:59:00PM +0100, Thomas Jespersen wrote:
> > > > This fixes warning reported by sparse (with -Wsparse-all).
> > >
> > > Why is sparse warning about this?
> >
> > Probably because it's the kernel preferred style
> > to use single statement
> >
> > do {
> > <foo>;
> > } while (<bar>);
> >
> > over
> >
> > by about a 20:1 ratio.
>
> Sparse is spitting out coding style complaints now?
To my own surprise, it's effectively sparse that complained:
warning: do-while statement is not a compound statement
with the flag -Wsparse-all (or -Wdo-while).
But -Wsparse-all is not a flag normally used for the kernel
(or normaly used on anything at all).
-- Luc
