Ray Lee wrote:
On 7/23/07, Nick Piggin <[EMAIL PROTECTED]> wrote:
That said, I'm willing to run my day to day life through both a swap prefetch kernel and a normal one. *However*, before I go through all the work of instrumenting the damn thing, I'd really like Andrew (or Linus) to lay out his acceptance criteria on the feature. Exactly what *should* I be paying attention to? I've suggested keeping track of process swapin delay total time, and comparing with and without. Is that reasonable? Is it incomplete?
I don't feel it is so useful without more context. For example, in most situations where pages get pushed to swap, there will *also* be useful file backed pages being thrown out. Swap prefetch might improve the total swapin delay time very significantly but that may be just a tiny portion of the real problem. Also a random day at the desktop, it is quite a broad scope and pretty well impossible to analyse. If we can first try looking at some specific problems that are easily identified. Looking at your past email, you have a 1GB desktop system and your overnight updatedb run is causing stuff to get swapped out such that swap prefetch makes it significantly better. This is really intriguing to me, and I would hope we can start by making this particular workload "not suck" without swap prefetch (and hopefully make it even better than it currently is with swap prefetch because we'll try not to evict useful file backed pages as well). After that we can look at other problems that swap prefetch helps with, or think of some ways to measure your "whole day" scenario. So when/if you have time, I can cook up a list of things to monitor and possibly a patch to add some instrumentation over this updatedb run. Anyway, I realise swap prefetching has some situations where it will fundamentally outperform even the page replacement oracle. This is why I haven't asked for it to be dropped: it isn't a bad idea at all. However, if we can improve basic page reclaim where it is obviously lacking, that is always preferable. eg: being a highly speculative operation, swap prefetch is not great for power efficiency -- but we still want laptop users to have a good experience as well, right? -- SUSE Labs, Novell Inc. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
