* Daniel Walker <[EMAIL PROTECTED]> wrote:
> > Not quite, it uses preempt_disable() to avoid migration and stick to
> > a cpu. Without that it might end up freeing pages from another
> > quicklist.
i.e. the patch hides a debug warning and there's possibly silent data
corruption - not good.
> > How about this - compile tested only
>
> How about a comment to go with it ? Which says something like what's
> above, notes on how the locking is getting used..
how about: "if you've got some time then please also add a few comments,
because the code was quite non-obvious to me and I misunderstood it when
I tried to fix it. Thanks."
ok?
Ingo
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
