[PATCH 2/3] x86_64: use core id bits for apicid_to_node initialization
We shoud use core id bits instead of max cores, in case later with AMD downcores Quad core Opteron. Signed-off-by: Yinghai Lu <[EMAIL PROTECTED]> k8topology.c | 14 +++++++++----- 1 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/arch/x86_64/mm/k8topology.c b/arch/x86_64/mm/k8topology.c index f983c75..d108f96 100644 --- a/arch/x86_64/mm/k8topology.c +++ b/arch/x86_64/mm/k8topology.c @@ -49,7 +49,9 @@ int __init k8_scan_nodes(unsigned long start, unsigned long end) int found = 0; u32 reg; unsigned numnodes; - unsigned dualcore = 0; + unsigned cores; + unsigned bits; + int j; if (!early_pci_allowed()) return -1; @@ -73,8 +75,6 @@ int __init k8_scan_nodes(unsigned long start, unsigned long end) unsigned long base,limit; u32 nodeid; - /* Undefined before E stepping, but hopefully 0 */ - dualcore |= ((read_pci_config(0, nb, 3, 0xe8) >> 12) & 3) == 1; base = read_pci_config(0, nb, 1, 0x40 + i*8); limit = read_pci_config(0, nb, 1, 0x44 + i*8); @@ -167,11 +167,15 @@ int __init k8_scan_nodes(unsigned long start, unsigned long end) } printk(KERN_INFO "Using node hash shift of %d\n", memnode_shift); + /* use the coreid bits from early_identify_cpu */ + bits = boot_cpu_data.x86_coreid_bits; + cores = (1<<bits); + for (i = 0; i < 8; i++) { if (nodes[i].start != nodes[i].end) { nodeid = nodeids[i]; - apicid_to_node[nodeid << dualcore] = i; - apicid_to_node[(nodeid << dualcore) + dualcore] = i; + for (j = 0; j < cores; j++) + apicid_to_node[(nodeid << bits) + j] = i; setup_node_bootmem(i, nodes[i].start, nodes[i].end); } }