On Sat, Jul 21, 2007 at 01:08:57AM +0200, Arnd Bergmann wrote: > On Saturday 21 July 2007, Sebastian Siewior wrote: > > > > Got with randconfig > > include/linux/loop.h:66: error: expected specifier-qualifier-list before > > 'request_queue_t' > > make[1]: *** [fs/compat_ioctl.o] Error 1 > > > > parts of compat ioctl require CONFIG_BLOCK to be set. > > > > Signed-off-by: Sebastian Siewior <[EMAIL PROTECTED]> > > Index: b/fs/compat_ioctl.c > > =================================================================== > > --- a/fs/compat_ioctl.c > > +++ b/fs/compat_ioctl.c > > @@ -63,7 +63,9 @@ > > ?#include <linux/wireless.h> > > ?#include <linux/atalk.h> > > ?#include <linux/blktrace_api.h> > > +#ifdef CONFIG_BLOCK > > ?#include <linux/loop.h> > > +#endif > > Adding #ifdef around an #include is considered bad style. Better just > make loop.h compile without any conditionals. Does the below > patch work for you?
That patch looks good, but even better would be adding a compat_ioctl handler to the loop driver. IIRC you even have an old patch for that :) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
