On Thu, 19 Jul 2007, Yinghai Lu wrote:
> > Index: linux/arch/x86_64/mm/srat.c
> > ===================================================================
> > --- linux.orig/arch/x86_64/mm/srat.c
> > +++ linux/arch/x86_64/mm/srat.c
> > /* maps to convert between proximity domain and logical node ID */
> > -static int pxm_to_node_map[MAX_PXM_DOMAINS]
> > +static int __cpuinitdata pxm_to_node_map[MAX_PXM_DOMAINS]
> > = { [0 ... MAX_PXM_DOMAINS - 1] = NID_INVAL
> > };
> > -static int node_to_pxm_map[MAX_NUMNODES]
> > +static int __cpuinitdata node_to_pxm_map[MAX_NUMNODES]
> > = { [0 ... MAX_NUMNODES - 1] = PXM_INVAL };
> >
> do we need to put __initdata just before =?
>
You mangled the quoting of this patch: the deltas above are actually in
drivers/acpi/numa.c and not arch/x86_64/mm/srat.c.
The placement of __cpuinitdata as shown above is permitted by gcc for a
section attribute. I've been corrected by akpm before when I've written
function declarations such as "static __init int foo()" in preference of
using the attribute syntax following all type qualifiers, but it is also
proper syntax. It's simply a matter of coding style, the semantics of the
construct are identical.
David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
