On Wed, Jul 18 2007, Hugh Dickins wrote: > On Wed, 18 Jul 2007, Jens Axboe wrote: > > > > OK, you clearly have more knowledge in that area than I, but I do wish > > that you would have made a note in the code at least to remove things > > like this. It's pretty ugly to have superflous tests like that, > > especially since there was not even a comment saying _why_ you could not > > call set_page_dirty() on a compound page. I see it in the commit text, > > but nobody looking at fs/bio.c or fs/direct-io.c would directly find any > > reference of that. > > > > Could you submit a patch removing the tests? > > Okay, I'll do that - once I've reminded myself how to test it and done so!
I'll do a test on this tomorrow and let you know what the results are! I should be able to do a quick fio job file for this, no need to write test cases :-) -- Jens Axboe - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
