Hi, Good stuff :)
> + int idlecount; /* number of empty packets */ should probably use tabs here. > + size = usb_control_msg(udev, usb_sndctrlpipe(udev, 0), > + ATP_GEYSER3_MODE_WRITE_REQUEST_ID, > + USB_DIR_OUT | USB_TYPE_CLASS | > USB_RECIP_INTERFACE, > + ATP_GEYSER3_MODE_REQUEST_VALUE, > + ATP_GEYSER3_MODE_REQUEST_INDEX, &data, 8, 5000); > + <eol> trailing whitespace. > + input_report_key(dev->input, BTN_LEFT, dev->data[dev->datalen-1] & 1); > + > @@ -449,10 +511,19 @@ static void atp_complete(struct urb* urb) > > /* reset the accumulator on release */ > memset(dev->xy_acc, 0, sizeof(dev->xy_acc)); > - } > > - input_report_key(dev->input, BTN_LEFT, > - !!dev->data[dev->datalen - 1]); Any hint as to why you move this? The different test, yes, ok, you explained that, but moving it? johannes
signature.asc
Description: This is a digitally signed message part
