Rusty Russell wrote:
> The patch seems fine, but the names are awkward. They've always been
> awkward (it's *userspace* helper, not *usermode* helper), but this just
> shines a bright light on them.
>
> So how about:
>
> call_usermodehelper_setup -> create_userspace_helper
> call_usermodehelper_<SET_EXTRA_STATE> -> userspace_helper_...
> call_usermodehelper_exec -> run_userspace_helper
>
> I can do that as a separate patch if you prefer (but it'd be nice to
> have it in the same merge window so the interface only churns once).
I don't have any particular objection, but I think it would be nicer if
they had a common prefix so that they're obviously related, and you can
easily infer the lifetime of the info structure.
J
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
