Ah, thanks for spelling it out for me :) I misunderstood you before. - Kevin
-----Original Message----- From: Oliver Neukum [mailto:[EMAIL PROTECTED] Sent: Monday, July 16, 2007 4:55 AM To: [EMAIL PROTECTED] Cc: Kevin Lloyd; [EMAIL PROTECTED]; Linux Development Group; [EMAIL PROTECTED]; linux-kernel@vger.kernel.org Subject: Re: [linux-usb-devel] [PATCH 01/02] USB: sierra: Add TRU-Install (c) Support [ATTEMPT 4] Am Freitag 13 Juli 2007 schrieb Kevin Lloyd: > +int sierra_probe(struct usb_interface *iface, const struct > +usb_device_id *id) { > + int result; > + struct usb_device *udev; > + > + udev = usb_get_dev(interface_to_usbdev(iface)); > + > + /* Check if in installer mode */ > + if (id->driver_info == DEVICE_INSTALLER){ > + dev_dbg(&udev->dev, "%s", "FOUND DEVICE(SW)\n"); > + result = sierra_set_ms_mode(udev, > +SWIMS_SET_MODE_Modem); > + return result; As I mentioned, you'd better return -EIO here. You don't want to bind to the device, as it is not yet a serial device and you want the driver core to stop trying while it goes away and transforms itself. Regards Oliver - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
