On Sunday 15 July 2007 11:16:56 Bryan Wu wrote: > In current Blackfin DMA allocation/free, the return value from > bfin_mac_alloc() is used as the dma_handle, here it is the > tx_desc/rx_desc. > The "dma_handle" is useless in the following code.
I think a comment has to be added, at least, as it's very confusing. > This is some magic code for PHY ID. In the future, we will rewrite some > code based on kernel phy abstraction layer to support more phy device. Ok, nice idea. > > Unwind the allocations above, if registering fails. > > > > In fact, it is safe. Because if registering fails, bf537mac_probe will > return none zero to bfin_mac_probe which will do free_netdev. Hm, weren't there some DMA allocations, too? Are they free'd properly? -- Greetings Michael. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
