Hi Julia, Thank you for the patch, but it doesn't apply to LED tree.
The patch causing the problem is out-of-LED-tree. Best regards, Jacek Anaszewski On 12/6/18 9:28 PM, Julia Lawall wrote:
Hello, The code seems to be wrong in several ways. If the continue is wanted, the of_node_put is not needed; it will happen on the next iteration. If the continue is not wanted, the of_node_put is needed, and the continue should be dropped. julia ---------- Forwarded message ---------- Date: Thu, 6 Dec 2018 19:48:54 +0800 From: kbuild test robot <[email protected]> To: [email protected] Cc: Julia Lawall <[email protected]> Subject: [PATCH] leds: tlc591xx: fix device_node_continue.cocci warnings CC: [email protected] TO: Jyri Sarha <[email protected]> CC: Peter Ujfalusi <[email protected]> CC: Jacek Anaszewski <[email protected]> CC: Pavel Machek <[email protected]> CC: [email protected] CC: [email protected] From: kbuild test robot <[email protected]> drivers/leds/leds-tlc591xx.c:342:3-14: ERROR: probable double put. Device node iterators put the previous value of the index variable, so an explicit put causes a double put. Generated by: scripts/coccinelle/iterators/device_node_continue.cocci Fixes: 7b2d34aaede7 ("leds: tlc591xx: Add gpio output support") CC: Jyri Sarha <[email protected]> Signed-off-by: kbuild test robot <[email protected]> --- tree: https://github.com/omap-audio/linux-audio peter/ti-linux-4.19.y/wip head: 838f24e2deaf1229002bd6555eb7e889b09ac1f9 commit: 7b2d34aaede727b4abfc78061bbd2202fcd92bc8 [62/67] leds: tlc591xx: Add gpio output support :::::: branch date: 26 hours ago :::::: commit date: 26 hours ago Please take the patch only if it's a positive warning. Thanks! leds-tlc591xx.c | 1 - 1 file changed, 1 deletion(-) --- a/drivers/leds/leds-tlc591xx.c +++ b/drivers/leds/leds-tlc591xx.c @@ -339,7 +339,6 @@ tlc591xx_probe(struct i2c_client *client for_each_child_of_node(np, child) { err = of_property_read_u32(child, "reg", ®); if (err) { - of_node_put(child); continue; return err; }
