On Tue, Dec 4, 2018 at 2:15 AM Frank Lee <[email protected]> wrote: > > On Mon, Dec 3, 2018 at 5:14 PM Rafael J. Wysocki <[email protected]> wrote: > > > > On Fri, Nov 30, 2018 at 3:26 PM Yangtao Li <[email protected]> wrote: > > > > > > In a function whose return type is void, returning on the last line is > > > not required.So remove it.Also move the module declaration to the end. > > > > The last piece is not reflected by the subject. > > > > Also, why do you move the MODULE_ stuff around at all? > When writing a driver, in most cases MODULE_ are put to the end. > Why not modify this? it is more in line with the habits of most people.
If you write a new driver, then yes. But why do you want to modify existing drivers this way? What value do you see in those changes, exactly?
