Michael Kelley <mikel...@microsoft.com> writes:

> From: Vitaly Kuznetsov <vkuzn...@redhat.com>  Sent: Friday, November 30, 2018 
> 4:54 AM
>> 
>> @@ -466,7 +466,7 @@ union hv_message_flags {
>>      struct {
>>              __u8 msg_pending:1;
>>              __u8 reserved:7;
>> -    };
>> +    } __packed;
>>  };
>> 
>>  /* Define port identifier type. */
>
> I think __packed is also needed in the definition
> of struct u defined within union hv_port_id.  That
> struct has bit fields, so shouldn't it be done just like
> union hv_message_flags above?
>

True, missed it, thanks! Will send v3 out shortly.

-- 
Vitaly

Reply via email to