>> + >> +/* acpitb.c */ >> +#define BOOT_STRING >> +extern int kstrtoull(const char *s, unsigned int base, unsigned long long >> *res); >> diff --git a/lib/kstrtox.c b/lib/kstrtox.c >> index 1006bf70bf74..a0ac1b2257b8 100644 >> --- a/lib/kstrtox.c >> +++ b/lib/kstrtox.c >> @@ -126,6 +126,9 @@ int kstrtoull(const char *s, unsigned int base, unsigned >> long long *res) >> } >> EXPORT_SYMBOL(kstrtoull); >> >> +/* Make compressed period code be able to use kstrtoull(). */ >> +#ifndef BOOT_STRING > >I got the following build error. > >]$ make arch/x86/boot/compressed/misc.o > CALL scripts/checksyscalls.sh > DESCEND objtool > CC arch/x86/boot/compressed/misc.o >ld: -r and -pie may not be used together >make[1]: *** [scripts/Makefile.build:294: arch/x86/boot/compressed/misc.o] >Error 1 >make: *** [Makefile:1715: arch/x86/boot/compressed/misc.o] Error 2 >]$
Hi Masa, So many thanks for your test. Could you give me more details about this error? More error message. Just on the first commit or the whole PATCHSET? Cause I didn't get error both on this commit and on the whole PATCHSET. Thanks, Chao Fan > >I think this error gets fixed by changing the BOOT_STRING ifndef >order before the EXPORT_SYMBOL, like this: > >#ifndef BOOT_STRING >EXPORT_SYMBOL(kstrtoull); > >I'm not sure this change is a good way... > >Thanks, >Masa > >
