On 23/11/18 10:20, Arnd Bergmann wrote: > On Thu, Nov 22, 2018 at 12:41 PM Roger Quadros <rog...@ti.com> wrote: > >> + >> + if (IS_ERR_OR_NULL(rproc)) >> + return ERR_PTR(-EINVAL); > > > Any usage of IS_ERR_OR_NULL() tends to be an indication of a badly > designed API. Please change this to allow only one of the two to be passed > around.
The user of this API has to call pru_rproc_get() which never returns NULL. So IS_ERR() should suffice here. > > Arnd > cheers, -roger -- Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
