Hi Palmer, On Thu, Nov 22, 2018 at 12:28 AM Palmer Dabbelt <pal...@sifive.com> wrote: > > On Tue, 20 Nov 2018 21:06:18 PST (-0800), bmeng...@gmail.com wrote: > > On Mon, Nov 12, 2018 at 1:55 PM Anup Patel <a...@brainfault.org> wrote: > >> > >> This patch extends Linux RISC-V build system to build and install: > >> Image - Flat uncompressed kernel image > >> Image.gz - Flat and GZip compressed kernel image > >> > >> Quiet a few bootloaders (such as Uboot, UEFI, etc) are capable of > > > > nits: U-Boot > > > >> booting flat and compressed kernel images. In case of Uboot, booting > > > > nits: U-Boot > > Thanks for the review. The PR has already been tagged, but it's not scheduled > to be sent out until later today. I generally try to avoid rewriting the tags > unless there's something major that's wrong, so unless you feel very strongly > about this then I think I'll let it stand. > > Let me know if this is a big deal for you, I can rewrite things. > > >> Image or Image.gz is achieved using bootm command. > >> > >> The flat and uncompressed kernel image (i.e. Image) is very useful > >> in pre-silicon developent and testing because we can create back-door > >> HEX files for RAM on FPGAs from Image. > >> > >> Signed-off-by: Anup Patel <a...@brainfault.org> > >> --- > >> arch/riscv/Makefile | 15 ++++++++- > >> arch/riscv/boot/.gitignore | 2 ++ > >> arch/riscv/boot/Makefile | 33 ++++++++++++++++++ > >> arch/riscv/boot/install.sh | 60 +++++++++++++++++++++++++++++++++ > >> arch/riscv/kernel/head.S | 10 ++++++ > >> arch/riscv/kernel/vmlinux.lds.S | 2 +- > >> 6 files changed, 120 insertions(+), 2 deletions(-) > >> create mode 100644 arch/riscv/boot/.gitignore > >> create mode 100644 arch/riscv/boot/Makefile > >> create mode 100644 arch/riscv/boot/install.sh > >> > > > > Reviewed-by: Bin Meng <bmeng...@gmail.com> > > > > Tested with U-Boot s-mode on QEMU virt, using bootm to boot the kernel > > Tested-by: Bin Meng <bmeng...@gmail.com> > > I also won't include the tags unless I rewrite the tags. > > Thanks for the review!
Thanks. Let's go with this as it's a minor nits. Regards, Bin
