On Wed, Jul 11, 2007 at 05:39:23PM -0700, Greg KH wrote:
> > This seems like a regression. We go from having an empty inline
> > function that gets optimised away to 0 to having a function call to a
> > trivial function. And on any architecture that *does* define this,
> > (unless I misunderstand the GCC manual), we still include the weak
> > definition, thus wasting space.
>
> Yeah, but it can be a big pain to add it to every architecture when only
> 1 or two need it, which is why I see people using the week symbol stuff
> more and more, right? This is just following that trend.
But it's already there. Deleting it now is pointless.
If someone really wants to unify it, better to do:
#ifndef PCIBIOS_PLATFORM_ENTRIES
static inline void pcibios_add_platform_entries(struct pci_dev *dev)
{
}
#endif
in <linux/pci.h> and then PPC can #define PCIBIOS_PLATFORM_ENTRIES
and do its own funky stuff. This weak symbol stuff has its uses, but
I don't think this is an appropriate use.
--
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
