On Thu, Nov 15, 2018 at 04:32:01PM -0800, Stanislav Fomichev wrote:
> Current libbfd feature test unconditionally links against -liberty and -lz.
> While it's required on some systems (e.g. opensuse), it's completely
> unnecessary on the others, where only -lbdf is sufficient (debian).
> This patch streamlines (and renames) the following feature checks:
>
> feature-libbfd - only link against -lbfd (debian),
> see commit 2cf9040714f3 ("perf tools: Fix bfd
> dependency libraries detection")
> feature-libbfd-liberty - link against -lbfd and -liberty
> feature-libbfd-liberty-z - link against -lbfd, -liberty and -lz (opensuse),
> see commit 280e7c48c3b8 ("perf tools: fix BFD
> detection on opensuse")
>
> (feature-liberty{,-z} were renamed to feature-libbfd-liberty{,z}
> for clarity)
>
> The main motivation is to fix this feature test for bpftool which is
> currently broken on debian (libbfd feature shows OFF, but we still
> unconditionally link against -lbfd and it works).
>
> Tested on debian with only -lbfd installed (without -liberty); I'd
> appreciate if somebody on the other systems can test this new detection
> method.
>
> Signed-off-by: Stanislav Fomichev <s...@google.com>
looks good, Fedora goes with standalone libbfd
Acked-by: Jiri Olsa <jo...@kernel.org>
thanks,
jirka
