On Thu, Nov 15, 2018 at 11:27:06AM -0600, Bjorn Helgaas wrote: > > > OK, I think I'll remove the insteadOf chunk from my .gitconfig. Should > > > https://korg.wiki.kernel.org/userdoc/gitolite be updated to remove or > > > expand that recommendation? The only reason I added insteadOf in the > > > first > > > place was because it sounded like a security improvement. > > > > It is. Does adding the insteadOf rules result in ssh:// URLs when using > > git-request-pull? I didn't expect that it would. > > Yep, it seems to for me. Maybe I'm doing something else weird, because I > don't see many other pull requests with ssh:// URLs.
Hmm, you're right -- I just tested this and it does. I can't imagine that's the intended effect of insteadOf -- it's supposed to alter URLs behind the scenes, not permanently transform them. I'll talk to git folks about it. For now, you should probably remove that from your gitconfig so that your pull requests have public URLs in them. Best, -K
