Looks good on a 32 socket system. All 64 memory controllers show up and I'm able to see the same sysfs diff. Thanks -Justin
> -----Original Message----- > From: Borislav Petkov [mailto:b...@alien8.de] > Sent: Tuesday, November 6, 2018 8:46 AM > To: Ernst, Justin <justin.er...@hpe.com>; Luck, Tony <tony.l...@intel.com> > Cc: Greg KH <gre...@linuxfoundation.org>; Anderson, Russ > <russ.ander...@hpe.com>; Mauro Carvalho Chehab > <mche...@kernel.org>; linux-e...@vger.kernel.org; linux- > ker...@vger.kernel.org; Aristeu Rozanski Filho <aroza...@redhat.com> > Subject: Re: [PATCH] EDAC: Don't add devices under /sys/bus/edac > > On Tue, Oct 02, 2018 at 06:26:08PM +0200, Borislav Petkov wrote: > > On Tue, Oct 02, 2018 at 03:51:41PM +0000, Ernst, Justin wrote: > > > The combined patches work on a 20 socket system. > > > Thanks! > > > > Cool, thanks for testing. > > > > Nevertheless, I'll queue them for 4.21 so that we have a full cycle of > > testing before we really kill the bus thing. > > Ok, I've pushed the two patches ontop of EDAC's for-next branch, here: > > https://git.kernel.org/pub/scm/linux/kernel/git/bp/bp.git/log/?h=edac-for- > 4.21-bus > > and I'd appreciate testing them one more time on the big boxes you guys > have. > > Diffing sysfs here shows this: > > --- edac.before 2018-11-06 13:37:37.925448609 +0100 > +++ edac.after 2018-11-06 15:36:11.229497795 +0100 > @@ -37,7 +37,6 @@ > /sys/devices/system/edac/mc/mc0/dimm3/power/control > /sys/devices/system/edac/mc/mc0/dimm3/dimm_dev_type > /sys/devices/system/edac/mc/mc0/dimm3/size > -/sys/devices/system/edac/mc/mc0/dimm3/subsystem > /sys/devices/system/edac/mc/mc0/dimm3/dimm_ce_count > /sys/devices/system/edac/mc/mc0/dimm3/dimm_label > /sys/devices/system/edac/mc/mc0/dimm3/dimm_location > > which is the bus symlink: > > subsystem -> ../../../../../../bus/mc0 > > and I think that's ok as nothing should be using it. > > Thx. > > -- > Regards/Gruss, > Boris. > > Good mailing practices for 400: avoid top-posting and trim the reply.
