On Sun, 8 Jul 2007, Ulrich Drepper wrote:
>
> But the real permissions tests are performed in notify_change. I think
> all this is consistent with how, for instance, fchmod works. The
> additional tests in fchmod which aren't here (IS_RDONLY and IS_APPEND)
> would also apply to the case where a file name is given. So, either the
> code was inconsistent already are these tests are really not needed.
No.
notify_change() does *not* do permission checks for
ATTR_CTIME/MTIME/ATIME.
It does them for the "xxx_SET" attributes, but MTIME/ATIME is expected to
change when other things change, so notify_change() expects that those
_other_ changes have been validated from a security standpoint!
utimes() is special.
Linus
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
