On Fri, Sep 28, 2018 at 05:07:04PM +0100, Alan Cox wrote: > > > SILVERMONT_CLIENT 0x37 Baytrail, Valleyview > > There is no such product as Valleyview. Some things talk about > Valleyview 2 but shouldn't as that is Baytrail.
I couldn't find it either, but it is all over the linux code. I'd be happy to remove it from this comment though. > > /* "Small Core" Processors (Atom) */ > > > > #define INTEL_FAM6_ATOM_BONNELL 0x1C /* Diamondville, Pineview > > */ > > #define INTEL_FAM6_ATOM_BONNELL_MID 0x26 /* Silverthorne, Lincroft */ > > > > #define INTEL_FAM6_ATOM_SALTWELL 0x36 /* Cedarview */ > > #define INTEL_FAM6_ATOM_SALTWELL_MID 0x27 /* Penwell */ > > #define INTEL_FAM6_ATOM_SALTWELL_TABLET 0x35 /* Cloverview */ > > > > #define INTEL_FAM6_ATOM_SILVERMONT 0x37 /* Bay Trail, Valleyview */ > > #define INTEL_FAM6_ATOM_SILVERMONT_X 0x4D /* Avaton, Rangely */ > > #define INTEL_FAM6_ATOM_SILVERMONT_MID 0x4A /* Merriefield */ > > > > #define INTEL_FAM6_ATOM_AIRMONT 0x4C /* Cherry Trail, Braswell > > */ > > #define INTEL_FAM6_ATOM_AIRMONT_MID 0x5A /* Moorefield */ > > > > #define INTEL_FAM6_ATOM_GOLDMONT 0x5C /* Apollo Lake */ > > #define INTEL_FAM6_ATOM_GOLDMONT_X 0x5F /* Denvertor */ > > #define INTEL_FAM6_ATOM_GOLDMONT_PLUS 0x7A /* Gemini Lake */ > > Can you decide if you are going to consistently use the -view or the > -trail naming ? I think for our use cases you mean Pinetrail, Cedartrail, > Clovertrail, Cherrytrail as you are talking about platform (at least in > the Intel sense of the word). Like I said; I went with whatever is on this here page: https://en.wikipedia.org/wiki/List_of_Intel_Atom_microprocessors There is no Cedar Trail, or Bayview. If you could do me a delta patch with the names you think are appropriate i'd be happy to fold it in. Alternatively, I can remove the tail comments entirely. I spend entirely too much time already trying to come up with sensible names already.
