Hi,
On Tue, Sep 25, 2018 at 8:05 AM Veerabhadrarao Badiganti
<vbadi...@codeaurora.org> wrote:
> + /*
> + * Whenever core-clock is gated dynamically, it's needed to
> + * re-initialize the DLL when the clock is ungated.
> + */
> + if (msm_host->restore_dll_cfg_needed && msm_host->clk_rate) {
> + msm_host->restore_dll_cfg = true;
> + mmc_retune_needed(host->mmc);
Using the boolean "restore_dll_cfg" to communicate like this seems
really fragile. I have no basis in fact, but I worry that something
will happen in the meantime that really ought to invalidate the
"saved_tuning_phase" but the boolean will still be set.
Is there a reason you can't just call msm_config_cm_dll_phase()
directly from sdhci_msm_runtime_resume()? Perhaps after the
clk_bulk_prepare_enable() call below?
-Doug
