On Mon, Sep 24, 2018 at 2:09 PM Andy Shevchenko <andy.shevche...@gmail.com> wrote: > > On Mon, Sep 24, 2018 at 8:04 PM Rajat Jain <raja...@google.com> wrote: > > On Mon, Sep 24, 2018 at 7:54 AM Banik, Subrata <subrata.ba...@intel.com> > > wrote: > > > > First of all, this is pre-production chip, so, I don't think there is a > > > bug in the driver (yet) discovered. > > > > > > Looking to the above ASL code I may conclude that is definitely is *not* > > > from our reference BIOS. > > > I have checked two versions of it and found that in both we have the > > > following mapping: > > > for LP variant: there are only 4 communities are exported for H variant: > > > there are only 5 communities are exported > > > > > > So, I guess the problem is in ASL code you provided. It simple should not > > > export that community at all. > > > > > > In case you need to do so, there are ways: > > > - contact Intel and ask for a change in reference BIOS > > > - acquire another ACPI ID for the case, or, perhaps use special > > > constants like > > > _HRV for that purpose (also need to contact Intel while doing that) > > > > As Subrata clarified (Subrata & Aamir are from Intel's Coreboot team), > > that is not *the* Intel reference BIOS that you are using, but it is > > *an* Intel generated BIOS/Coreboot image. > > Ah, interesting. > > > Andy, can you please let us know in what order are the resources laid > > out in your reference BIOS for the case when it exports 5 communities > > (i.e. community-0-2, 4-5)? > > We have no hardware with such PCH to answer to this question. LP > version exports only 4 communities and order of them as per existing > driver.
Got it, thanks. From your response earlier: > Looking to the above ASL code I may conclude that is definitely is *not* from > our reference BIOS. > I have checked two versions of it and found that in both we have the > following mapping: > for LP variant: there are only 4 communities are exported > for H variant: there are only 5 communities are exported 1) Do you know or recall, the order of communities in ACPI in the H variant? Of course, this is a request for help for getting the info. 2) Trying to understand how would the kernel support both LP and H variant. Is it the assumption that the H variant will have a different ACPI ID than the LP variant (i.e. not "INT3455")? Because it will also have the same problem that we are seeing I think. Thanks for all your help, Rajat > > > -- > With Best Regards, > Andy Shevchenko
