On Mon, Sep 17, 2018 at 08:19:50PM -0700, Stefan Agner wrote: > On 13.09.2018 16:59, Miguel Ojeda wrote: > > The naked attribute is supported by at least gcc >= 4.6 (for ARM, > > which is the only current user), gcc >= 8 (for x86), clang >= 3.1 > > and icc >= 13. See https://godbolt.org/z/350Dyc > > > > Therefore, move it out of compiler-gcc.h so that the definition > > is shared by all compilers. > > > > This also fixes Clang support for ARM32 --- 815f0ddb346c > > ("include/linux/compiler*.h: make compiler-*.h mutually exclusive"). > > > > Cc: Stefan Agner <ste...@agner.ch> > > Cc: Rasmus Villemoes <li...@rasmusvillemoes.dk> > > Cc: Eli Friedman <efrie...@codeaurora.org> > > Cc: Christopher Li <spa...@chrisli.org> > > Cc: Kees Cook <keesc...@chromium.org> > > Cc: Ingo Molnar <mi...@kernel.org> > > Cc: Geert Uytterhoeven <ge...@linux-m68k.org> > > Cc: Greg Kroah-Hartman <gre...@linuxfoundation.org> > > Cc: Masahiro Yamada <yamada.masah...@socionext.com> > > Cc: Joe Perches <j...@perches.com> > > Cc: Dominique Martinet <asmad...@codewreck.org> > > Cc: Linus Torvalds <torva...@linux-foundation.org> > > Cc: linux-spa...@vger.kernel.org > > Suggested-by: Arnd Bergmann <a...@arndb.de> > > Reviewed-by: Luc Van Oostenryck <luc.vanoostenr...@gmail.com> > > Reviewed-by: Nick Desaulniers <ndesaulni...@google.com> > > Signed-off-by: Miguel Ojeda <miguel.ojeda.sando...@gmail.com> > > Reviewed-by: Stefan Agner <ste...@agner.ch> > > Ideally this two patches should go into v4.19. Not sure which path the patch > should take, MAINTAINERS is not quite clear about that. This fixes > 815f0ddb346c ("include/linux/compiler*.h: make compiler-*.h mutually > exclusive") for ARM32, which has been merged directly by > Linus, afaict...
Good point, can you resend these to me with all of the acks added so far? thanks, greg k-h
