On Fri, 31 Aug 2018, Philipp Zabel wrote: > Commit 1c892e38ce59 ("regulator: da9063: Handle less LDOs on DA9063L") > reordered the da9063_regulator_info[] array, but not the DA9063_ID_* > regulator ids and not the da9063_matches[] array, because ids are used > as indices in the array initializer. This mismatch between regulator id > and da9063_regulator_info[] array index causes the driver probe to fail > because constraints from DT are not applied to the correct regulator: > > da9063 0-0058: Device detected (chip-ID: 0x61, var-ID: 0x50) > DA9063_BMEM: Bringing 900000uV into 3300000-3300000uV > DA9063_LDO9: Bringing 3300000uV into 2500000-2500000uV > DA9063_LDO1: Bringing 900000uV into 3300000-3300000uV > DA9063_LDO1: failed to apply 3300000-3300000uV constraint(-22) > > This patch reorders the DA9063_ID_* as apparently intended, and with > them the entries in the da90630_matches[] array. > > Fixes: 1c892e38ce59 ("regulator: da9063: Handle less LDOs on DA9063L") > Signed-off-by: Philipp Zabel <p.za...@pengutronix.de> > Cc: Marek Vasut <marek.vasut+rene...@gmail.com> > Cc: Mark Brown <broo...@kernel.org> > Cc: Geert Uytterhoeven <geert+rene...@glider.be> > Cc: Lee Jones <lee.jo...@linaro.org> > --- > include/linux/mfd/da9063/pdata.h | 16 +++++++++------- > 1 file changed, 9 insertions(+), 7 deletions(-)
This is an MFD patch. I'll make the necessary changes and apply it. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog