On Wed, 29 Aug 2018 21:20:07 -0700 Josh Triplett <j...@joshtriplett.org> wrote:
> > And please see below for what the resulting diff would look like. Is > > this an improvement? > > Honestly, as long as the result after each commit compiles, I prefer the > split version for ease of review. You and I have different preferences for reviewing changes like this ;-) I prefer the one patch (I do think it is an improvement). It's all basically the exact same change. Looking at 40 different patches is much more work IMHO, then just looking at a single patch, and testing it, then testing 40 different patches. That's a lot of compiling. I usually stop reviewing after 10 patches of the same kind, as I run out of time to review them. -- Steve
