On Fri, Aug 24, 2018 at 8:52 AM Will Deacon <will.dea...@arm.com> wrote: > > Now that our walk-cache invalidation routines imply a DSB before the > invalidation, we no longer need one when we are clearing an entry during > unmap.
Do you really still need it when *setting* it? I'm wondering if you could just remove the thing unconditionally. Why would you need a barrier for another CPU for a mapping that is just being created? It's ok if they see the old lack of mapping until they are told about it, and that eventual "being told about it" must involve a data transfer already. And I'm assuming arm doesn't cache negative page table entries, so there's no issue with any stale tlb. And any other kernel thread looking at the page tables will have to honor the page table locking, so you don't need it for some direct page table lookup either. Hmm? It seems like you shouldn't need to order the "set page directory entry" with anything. But maybe there's some magic arm64 rule I'm not aware of. Maybe even the local TLB hardware walker isn't coherent with local stores? Linus