Hi Dou,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on pm/linux-next]
[also build test ERROR on v4.18 next-20180822]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:    
https://github.com/0day-ci/linux/commits/Dou-Liyang/acpi-processor-Fix-the-return-value-of-acpi_processor_ids_walk/20180823-165002
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git 
linux-next
config: i386-randconfig-h0-08231413 (attached as .config)
compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   drivers//acpi/acpi_processor.c: In function 'acpi_processor_ids_walk':
>> drivers//acpi/acpi_processor.c:646:3: error: implicit declaration of 
>> function 'acpi_ut_status_exit' [-Werror=implicit-function-declaration]
      return_ACPI_STATUS(status);
      ^
   cc1: some warnings being treated as errors

vim +/acpi_ut_status_exit +646 drivers//acpi/acpi_processor.c

   632  
   633  static acpi_status __init acpi_processor_ids_walk(acpi_handle handle,
   634                                                    u32 lvl,
   635                                                    void *context,
   636                                                    void **rv)
   637  {
   638          acpi_status status;
   639          acpi_object_type acpi_type;
   640          unsigned long long uid;
   641          union acpi_object object = { 0 };
   642          struct acpi_buffer buffer = { sizeof(union acpi_object), 
&object };
   643  
   644          status = acpi_get_type(handle, &acpi_type);
   645          if (ACPI_FAILURE(status))
 > 646                  return_ACPI_STATUS(status);
   647  
   648          switch (acpi_type) {
   649          case ACPI_TYPE_PROCESSOR:
   650                  status = acpi_evaluate_object(handle, NULL, NULL, 
&buffer);
   651                  if (ACPI_FAILURE(status))
   652                          goto err;
   653                  uid = object.processor.proc_id;
   654                  break;
   655  
   656          case ACPI_TYPE_DEVICE:
   657                  status = acpi_evaluate_integer(handle, "_UID", NULL, 
&uid);
   658                  if (ACPI_FAILURE(status))
   659                          goto err;
   660                  break;
   661          default:
   662                  goto err;
   663          }
   664  
   665          processor_validated_ids_update(uid);
   666          return AE_OK;
   667  
   668  err:
   669          /* Exit on error, but don't abort the namespace walk */
   670          acpi_handle_info(handle, "Invalid processor object\n");
   671          return AE_OK;
   672  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

Reply via email to