On Tue, 2007-06-26 at 20:13 +0200, Rodolfo Giometti wrote: > On Tue, Jun 26, 2007 at 06:38:40PM +0100, David Woodhouse wrote: > > > That sounds like you're scared of using goto. Don't be :) > > But it's not wrong... should I change it or not?
I would suggest changing it. It makes it more obvious to the casual that there are no other callers of the 'internal' functions. It's a matter of taste though; if you feel _very_ strongly about it then feel free to ignore me. > Is this right? > +unifdef-y += pps.h Yes, that looks right. As a matter of course you should also run 'make headers_check' before submitting your new patch, to make sure everything is sane. That'll tell you if your exported pps.h is trying to include other header files which aren't also exported. -- dwmw2 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
