On Mon, Aug 20, 2018 at 5:40 PM Thomas Gleixner <t...@linutronix.de> wrote: > > On Tue, 14 Aug 2018, Arnd Bergmann wrote: > > > A new build error appeared with CONFIG_PROC_FS disabled: > > > > arch/x86/kernel/apm_32.c:1643:12: error: 'proc_apm_show' defined but not > > used [-Werror=unused-function] > > > > This marks the function as __maybe_unused to let the compiler drop > > it silently. > > > > Fixes: 3f3942aca6da ("proc: introduce proc_create_single{,_data}") > > The proper fix for this is to convert the stub function for proc_apm_show() > to an inline. The compiler complains because the stub is a macro ....
I even did that https://patchwork.ozlabs.org/patch/920786/ but then a handful of patches went into the kernel to add #ifdefs around the other proc_show functions, so it no longer applied. These two are the only remaining ones. Arnd