Hi Zhong Jiang,

Thank you for the patch.

On Saturday, 18 August 2018 13:57:12 EEST zhong jiang wrote:
> We prefer to ERR_CAST rather than ERR_PTR(PTR_ERR()), So just
> replace it.
> 
> The issue is detected with the help of Coccinelle
> 
> Signed-off-by: zhong jiang <zhongji...@huawei.com>

Reviewed-by: Laurent Pinchart <laurent.pinch...@ideasonboard.com>

> ---
>  drivers/gpu/drm/omapdrm/dss/dss.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/omapdrm/dss/dss.c
> b/drivers/gpu/drm/omapdrm/dss/dss.c index cb80dda..1fc46b2 100644
> --- a/drivers/gpu/drm/omapdrm/dss/dss.c
> +++ b/drivers/gpu/drm/omapdrm/dss/dss.c
> @@ -956,7 +956,7 @@ struct dss_debugfs_entry *
>                               &dss_debug_fops);
>       if (IS_ERR(d)) {
>               kfree(entry);
> -             return ERR_PTR(PTR_ERR(d));
> +             return ERR_CAST(d);
>       }
> 
>       entry->dentry = d;

-- 
Regards,

Laurent Pinchart



Reply via email to