On Sat, 2018-08-18 at 18:53 +0300, Sergei Shtylyov wrote: > On 08/18/2018 09:16 AM, zhong jiang wrote: > > > We should use NULL to compare with pointer-typed value rather than > > 0. The issue is detected with the help of Coccinelle. > > Your description stopped to match the patch in v2. > Actually, this X == NULL to !x preference is largely spocific to netdev... > Although, IDE maintainer is the same now person. :-) > > > Signed-off-by: zhong jiang <zhongji...@huawei.com> > > --- > > drivers/ide/pmac.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/ide/pmac.c b/drivers/ide/pmac.c > > index c5b902b..ca36a97 100644 > > --- a/drivers/ide/pmac.c > > +++ b/drivers/ide/pmac.c > > @@ -1682,7 +1682,7 @@ static int pmac_ide_init_dma(ide_hwif_t *hwif, const > > struct ide_port_info *d) > > /* We won't need pci_dev if we switch to generic consistent > > * DMA routines ... > > */ > > - if (dev == NULL || pmif->dma_regs == 0) > > + if (!dev || !pmif->dma_regs) > > return -ENODEV; > > /* > > * Allocate space for the DBDMA commands. > > MBR, Sergei
Perhaps discourage trivial changes to this old subsystem. checkpatch could bleat something if a patch was submitted for ide if the IDE MAINTAINERS entry was marked obsolete. --- diff --git a/MAINTAINERS b/MAINTAINERS index e9336962d0f2..3c4992cf5249 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -6933,7 +6933,7 @@ M: "David S. Miller" <da...@davemloft.net> L: linux-...@vger.kernel.org Q: http://patchwork.ozlabs.org/project/linux-ide/list/ T: git git://git.kernel.org/pub/scm/linux/kernel/git/davem/ide.git -S: Maintained +S: Maintained / Obsolete (prefer LIBATA) F: Documentation/ide/ F: drivers/ide/ F: include/linux/ide.h
