On Mon, 13 Aug 2018 11:24:48 +0200 Harald Freudenberger <fre...@linux.ibm.com> wrote:
> Here is now the add-on patch which changes the returncode for the > ap_instructions_available() function. > > I talked with Heiko Carstens and this patch will go into the next pull > request for the 4.19 kernel. I was just about to ask :) > > ----------------------------------------------------------------------------------------- > From 9e050f843f3281da1f65292422e30f2dd1fd6d98 Mon Sep 17 00:00:00 2001 > From: Harald Freudenberger <fre...@linux.ibm.com> > Date: Thu, 9 Aug 2018 11:59:34 +0200 > Subject: [PATCH] s390/zcrypt: fix ap_instructions_available() returncodes > > During review of KVM patches it was complained that the > ap_instructions_available() function returns 0 if AP > instructions are available and -ENODEV if not. The function > acts like a boolean function to check for AP instructions > available and thus should return 0 on failure and != 0 on > success. Changed to the suggested behaviour and adapted > the one and only caller of this function which is the ap > bus core code. > > Signed-off-by: Harald Freudenberger <fre...@linux.ibm.com> > --- > arch/s390/include/asm/ap.h | 10 +++++----- > drivers/s390/crypto/ap_bus.c | 2 +- > 2 files changed, 6 insertions(+), 6 deletions(-) Looks sane to me. Acked-by: Cornelia Huck <coh...@redhat.com>
