hi,
Milind reported that modify_user_hw_breakpoint wouldn't
allow the breakpoint changing if the new attr had 'disabled'
set to true.
I found a case where it actualy prevents ptrace user interface
to change the breakpoint. It's described in patch 1 as perf test,
patch 2 is the breakpoint code fix.
I ran strace tests, nothing (new) broken there..
thanks,
jirka
---
Jiri Olsa (2):
perf tests: Add breakpoint modify test
perf/hw_breakpoint: Modify breakpoint even if the new attr has disabled
set
kernel/events/hw_breakpoint.c | 10 ++++++----
tools/perf/arch/x86/include/arch-tests.h | 1 +
tools/perf/arch/x86/tests/Build | 1 +
tools/perf/arch/x86/tests/arch-tests.c | 6 ++++++
tools/perf/arch/x86/tests/bp-modify.c | 119
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
5 files changed, 133 insertions(+), 4 deletions(-)
create mode 100644 tools/perf/arch/x86/tests/bp-modify.c
