On Thu, 2018-08-02 at 23:20 +0200, Michal Zylowski wrote:
> Current checkpatch implementation permits notation like:
> } else{
> in kernel code.
> It looks like oversight and inconsistency in checkpatch rules (e.g.
> instruction like 'do' is tested).
>
> Add regex for checking space after 'else' keyword and trigger error if
> space is not present.
>
> Signed-off-by: Michal Zylowski <michal.zylow...@intel.com>
Acked-by: Joe Perches <j...@perches.com
though it might be better if the do and else
was written on a single line like:
$line =~ /\b(?:else|do)\{/
> ---
> scripts/checkpatch.pl | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index e16d671..2e3f41e 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -4479,6 +4479,7 @@ sub process {
>
> #need space before brace following if, while, etc
> if (($line =~ /\(.*\)\{/ && $line !~ /\($Type\)\{/) ||
> + $line =~ /else\{/ ||
> $line =~ /do\{/) {
> if (ERROR("SPACING",
> "space required before the open brace '{'\n"
> . $herecurr) &&
