On Thu, Aug 02, 2018 at 01:00:26PM +0000, Nixiaoming wrote: > On Wednesday, August 01, 2018 11:18 PM , J. Bruce Fields wrote: > >On Mon, Jul 23, 2018 at 09:57:11AM +0800, nixiaoming wrote: > >> READ_BUF(8); > >> dummy = be32_to_cpup(p++); > >> dummy = be32_to_cpup(p++); > >> ... > >> READ_BUF(4); > >> dummy = be32_to_cpup(p++); > >> > >> Assigning value to "dummy" here, but that stored value > >> is overwritten before it can be used. > >> At the same time READ_BUF() will re-update the pointer p. > >> > >> delete invalid assignment statements > > > >Thanks, applying with a minor comment tweak to clarify that we're > >intentionally not reading these: > > > >- /* ssp_window and ssp_num_gss_handles */ > >+ /* ignore ssp_window and ssp_num_gss_handles: */ > > READ_BUF(8); > > break; > > > >--b. > > > > Thanks for your advice > I will update the patch as soon as possible according to your advice.
I've taken care of it, no need to update. --b.
