Commit-ID:  d79d024820f2e522ab30b5e6662c245f887c752b
Gitweb:     https://git.kernel.org/tip/d79d024820f2e522ab30b5e6662c245f887c752b
Author:     Colin Ian King <colin.k...@canonical.com>
AuthorDate: Tue, 31 Jul 2018 10:09:38 +0100
Committer:  Thomas Gleixner <t...@linutronix.de>
CommitDate: Thu, 2 Aug 2018 14:25:41 +0200

x86/platform/UV: Remove redundant check of p == q

The check for p == q is dead code because the proceeding switch
statements jump to the end of the outer for-loop with continue
statements.  Remove the dead code.

Detected by CoverityScan, CID#145071 ("Structurally dead code")

Signed-off-by: Colin Ian King <colin.k...@canonical.com>
Signed-off-by: Thomas Gleixner <t...@linutronix.de>
Cc: "H . Peter Anvin" <h...@zytor.com>
Cc: kernel-janit...@vger.kernel.org
Link: https://lkml.kernel.org/r/20180731090938.11856-1-colin.k...@canonical.com

---
 arch/x86/platform/uv/tlb_uv.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/arch/x86/platform/uv/tlb_uv.c b/arch/x86/platform/uv/tlb_uv.c
index ca446da48fd2..e26dfad507c8 100644
--- a/arch/x86/platform/uv/tlb_uv.c
+++ b/arch/x86/platform/uv/tlb_uv.c
@@ -1607,8 +1607,6 @@ static int parse_tunables_write(struct bau_control *bcp, 
char *instr,
                                *tunables[cnt].tunp = val;
                        continue;
                }
-               if (q == p)
-                       break;
        }
        return 0;
 }

Reply via email to