4.14-stable review patch.  If anyone has any objections, please let me know.

------------------

From: Andrew Morton <a...@linux-foundation.org>

commit 06892cc190550807d332c95a0114c7e175584012 upstream.

gcc-4.4.4 has issues with initialization of anonymous unions:

drivers/infiniband/ulp/srpt/ib_srpt.c: In function 'srpt_zerolength_write':
drivers/infiniband/ulp/srpt/ib_srpt.c:854: error: unknown field 'wr_cqe' 
specified in initializer
drivers/infiniband/ulp/srpt/ib_srpt.c:854: warning: initialization makes 
integer from pointer without a cast

Work aound this.

Fixes: 2a78cb4db487 ("IB/srpt: Fix an out-of-bounds stack access in 
srpt_zerolength_write()")
Cc: Bart Van Assche <bart.vanass...@wdc.com>
Cc: Christoph Hellwig <h...@lst.de>
Cc: Jason Gunthorpe <j...@mellanox.com>
Cc: <sta...@vger.kernel.org>
Signed-off-by: Andrew Morton <a...@linux-foundation.org>
Signed-off-by: Doug Ledford <dledf...@redhat.com>
Signed-off-by: Sudip Mukherjee <sudipm.mukher...@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gre...@linuxfoundation.org>
---
 drivers/infiniband/ulp/srpt/ib_srpt.c |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- a/drivers/infiniband/ulp/srpt/ib_srpt.c
+++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
@@ -790,8 +790,9 @@ static int srpt_zerolength_write(struct
        struct ib_send_wr *bad_wr;
        struct ib_rdma_wr wr = {
                .wr = {
+                       .next           = NULL,
+                       { .wr_cqe       = &ch->zw_cqe, },
                        .opcode         = IB_WR_RDMA_WRITE,
-                       .wr_cqe         = &ch->zw_cqe,
                        .send_flags     = IB_SEND_SIGNALED,
                }
        };


Reply via email to