>On Thu, Jul 26, 2018 at 04:19:08PM +0800, Cheng Lin wrote:
>> - if (!cpumask_test_cpu(arg.dst_cpu, &arg.src_task->cpus_allowed)) >> + if ((!cpumask_test_cpu(arg.dst_cpu, &arg.src_task->cpus_allowed)) >> + || !housekeeping_test_cpu(arg.dst_cpu, HK_FLAG_DOMAIN)) >> goto out; > >You did not read the comment I provided last time. Using isolcpus (and >thus it's renamed houskeeping thing) is the wrong thing to do. Load >balancing should be limited to it's root domain. "isolcpus" is "[Deprecated - use cpusets instead]" in the lastest kernel(4.18). Before 4.15, the option "isolcpus" is "the preferred way to isolate CPUs". Although it is "Deprecated", but we also can use it in the lastest kernel. And now a large number of “isolcpus” are using in the old way. Whether NUMA-balancing should consider the “isolcpus” for forward compatibility? Or in some branches?
