On Wednesday 20 June 2007 20:24, Jiri Kosina wrote: > On Thu, 21 Jun 2007, Pavel Machek wrote: > > > > this has probably been already solved by proper throttling - see > > > http://lkml.org/lkml/2007/6/15/22 > > No, it was not. I still saw the problems with CONFIG_BLINK on, that is > > one blink per 5 seconds or something.
Pavel, does my patch fixes keyboard issues for you when blinking via setleds? > > We should rename CONFIG_BLINK to > > CONFIG_BREAK_THINKPAD_KEYBOARD_AND_MORE. Also CONFIG_KILL_MY_NOHZ_SAVINGS ;) > > In fact it looks quite weird that one blink per 5 seconds can break the > keyboard, in fact. Not wierd at all. The driver uses panic_blink - something that we expect to work after panic. It rapidly polls KBC status register to detect when it accepted led command and does it without taking i8042_lock (because it may have been taken before kernel panicked) so it is quite possible that that interferes with atkbd operation. IOW I am not really interested in reports regrading issues with keyboards and/or mice on boxes with blink driver loaded. -- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
