Hi Serge, I love your patch! Yet something to improve:
[auto build test ERROR on ntb/ntb-next] [also build test ERROR on v4.18-rc4 next-20180713] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Serge-Semin/ntb-idt-Add-hwmon-temperature-sensor-interface/20180714-203042 base: https://github.com/jonmason/ntb ntb-next config: i386-randconfig-sb0-07142045 (attached as .config) compiler: gcc-4.9 (Debian 4.9.4-2) 4.9.4 reproduce: # save the attached .config to linux build tree make ARCH=i386 :::::: branch date: 4 hours ago :::::: commit date: 4 hours ago All errors (new ones prefixed by >>): drivers/ntb/hw/idt/ntb_hw_idt.o: In function `idt_init_temp': >> drivers/ntb/hw/idt/ntb_hw_idt.c:2128: undefined reference to >> `devm_hwmon_device_register_with_groups' # https://github.com/0day-ci/linux/commit/e5df08844556d4987cb936b26a0423befaf2bfcc git remote add linux-review https://github.com/0day-ci/linux git remote update linux-review git checkout e5df08844556d4987cb936b26a0423befaf2bfcc vim +2128 drivers/ntb/hw/idt/ntb_hw_idt.c bf2a952d Serge Semin 2017-04-12 2108 e5df0884 Serge Semin 2018-07-14 2109 /* e5df0884 Serge Semin 2018-07-14 2110 * idt_init_temp() - initialize temperature sensor interface e5df0884 Serge Semin 2018-07-14 2111 * @ndev: IDT NTB hardware driver descriptor e5df0884 Serge Semin 2018-07-14 2112 * e5df0884 Serge Semin 2018-07-14 2113 * Simple sensor initializarion method is responsible for device switching e5df0884 Serge Semin 2018-07-14 2114 * on and resource management based hwmon interface registration. Note, that e5df0884 Serge Semin 2018-07-14 2115 * since the device is shared we won't disable it on remove, but leave it e5df0884 Serge Semin 2018-07-14 2116 * working until the system is powered off. e5df0884 Serge Semin 2018-07-14 2117 */ e5df0884 Serge Semin 2018-07-14 2118 static void idt_init_temp(struct idt_ntb_dev *ndev) e5df0884 Serge Semin 2018-07-14 2119 { e5df0884 Serge Semin 2018-07-14 2120 struct device *hwmon; e5df0884 Serge Semin 2018-07-14 2121 e5df0884 Serge Semin 2018-07-14 2122 /* Enable sensor if it hasn't been already */ e5df0884 Serge Semin 2018-07-14 2123 idt_sw_write(ndev, IDT_SW_TMPCTL, 0x0); e5df0884 Serge Semin 2018-07-14 2124 e5df0884 Serge Semin 2018-07-14 2125 /* Initialize hwmon interface fields */ e5df0884 Serge Semin 2018-07-14 2126 mutex_init(&ndev->hwmon_mtx); e5df0884 Serge Semin 2018-07-14 2127 e5df0884 Serge Semin 2018-07-14 @2128 hwmon = devm_hwmon_device_register_with_groups(&ndev->ntb.pdev->dev, e5df0884 Serge Semin 2018-07-14 2129 ndev->swcfg->name, ndev, idt_temp_groups); e5df0884 Serge Semin 2018-07-14 2130 if (IS_ERR(hwmon)) { e5df0884 Serge Semin 2018-07-14 2131 dev_err(&ndev->ntb.pdev->dev, "Couldn't create hwmon device"); e5df0884 Serge Semin 2018-07-14 2132 return; e5df0884 Serge Semin 2018-07-14 2133 } e5df0884 Serge Semin 2018-07-14 2134 e5df0884 Serge Semin 2018-07-14 2135 dev_dbg(&ndev->ntb.pdev->dev, "Temperature HWmon interface registered"); e5df0884 Serge Semin 2018-07-14 2136 } e5df0884 Serge Semin 2018-07-14 2137 --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
.config.gz
Description: application/gzip
