Hi, On Tue, May 08, 2018 at 10:16:31PM +0300, Alexey Khoroshilov wrote: > On 01.05.2018 15:39, Sebastian Reichel wrote: > > On Sun, Apr 29, 2018 at 01:35:55AM +0300, Alexey Khoroshilov wrote: > >> There is of_node_get(client->dev.of_node) in ltc294x_i2c_probe(), > >> but these is no of_node_put() somethere in the driver. > >> > >> The patch adds one on error and normal paths. > >> > >> Found by Linux Driver Verification project (linuxtesting.org). > >> > >> Signed-off-by: Alexey Khoroshilov <khoroshi...@ispras.ru> > > > > That is ugly. Let's replace of_property_read_u32(np, ...) with > > device_property_read_u32(dev, ...) and get rid of np instead. > > Ok, I will prepare v2. > > What is the right way to replace > info->supply_desc.name = np->name; > ? > > If lifetime of 'client->dev.of_node' = 'np' cannot be less than lifetime > of 'client->dev', should we use just > info->supply_desc.name = client->dev.of_node->name; > ?
It looks like I never responsed to this, sorry for the delay. Your suggestion looks fine. -- Sebastian
signature.asc
Description: PGP signature
